Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnnotationForge to Suggests #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martin-g
Copy link

@martin-g martin-g commented Aug 4, 2023

Solves the following R CMD check error:

 ERROR
Errors in running code in vignettes:
when running code in ‘GCSscore.Rnw’
  ...
*This package will only be generated once for each chip-type*
*Or if probeFile version for the chip-type needs to be updated*
writing intermediary .probe_tab file to temporary directory
Importing the data.
Warning in packageDescription(thispkg) :
  no package 'AnnotationForge' was found

  When sourcing ‘GCSscore.R’:
Error: $ operator is invalid for atomic vectors
Execution halted

It seems AnnotationForge is a transitive dependency that must be explicitly declared for Bioc 3.18, because of R_CHECK_SUGGESTS_ONLY=true

See https://support.bioconductor.org/p/9153573/#9153581 for more details.

Solves the following `R CMD check` error:
```
 ERROR
Errors in running code in vignettes:
when running code in ‘GCSscore.Rnw’
  ...
*This package will only be generated once for each chip-type*
*Or if probeFile version for the chip-type needs to be updated*
writing intermediary .probe_tab file to temporary directory
Importing the data.
Warning in packageDescription(thispkg) :
  no package 'AnnotationForge' was found

  When sourcing ‘GCSscore.R’:
Error: $ operator is invalid for atomic vectors
Execution halted
```
@martin-g
Copy link
Author

Friendly ping!

@hpages
Copy link

hpages commented Sep 27, 2023

@harrisgm Could you please take a look at this PR? Please be aware that Bioconductor will deprecate unmaintained packages. Don't hesitate to let me know or ask on the bioc-devel mailling list if you have any questions or concerns about this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants