Skip to content

Commit

Permalink
feat(chore): change to use .tool-versions for specifying Node.js version
Browse files Browse the repository at this point in the history
  • Loading branch information
haru52 committed May 17, 2024
1 parent fb161cc commit 3e68cd1
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version-file: .node-version
node-version-file: .tool-versions
cache: npm
- name: Install dependencies
run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v4
with:
node-version-file: .node-version
node-version-file: .tool-versions
cache: npm
- run: npm ci
- name: "Lint: credentials"
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
# - uses: actions/checkout@v4
# - uses: actions/setup-node@v4
# with:
# node-version-file: .node-version
# node-version-file: .tool-versions
# cache: npm
# - run: npm ci
# - run: npm run build
Expand All @@ -75,7 +75,7 @@ jobs:
# - uses: actions/checkout@v4
# - uses: actions/setup-node@v4
# with:
# node-version-file: .node-version
# node-version-file: .tool-versions
# cache: npm
# - run: npm ci
# - run: npm test
Expand Down
1 change: 0 additions & 1 deletion .node-version

This file was deleted.

1 change: 1 addition & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
actionlint 1.6.24
nodejs 18.16.0
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

| Tool | Version |
| ----------------------------------------------------------- | ----------------------------------------------------------------------------------------------------- |
| Node.js | [.node-version](https://github.com/haru52/base_template/blob/main/.node-version#L1) |
| Node.js | [.tool-versions](https://github.com/haru52/base_template/blob/main/.tool-versions#L2) |
| npm | `engines.npm` value in [package.json](https://github.com/haru52/base_template/blob/main/package.json) |
| [gibo](https://github.com/simonwhitaker/gibo#readme) | ^2.2.8 |
| [Vale CLI](https://vale.sh/) | ^2.27.0 |
Expand Down

0 comments on commit 3e68cd1

Please sign in to comment.