Update to bevy v0.11 and kira v0.8. #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think this is really cool work. I updated bevy_fundsp to work with bevy v0.11 and kira v0.8. I looked at updating bevy_oddio but it doesn't support bevy v0.11 yet.
This patch does make the examples work. However, the bevy_audio backend feels a little strange. DspSources can now be directly added as assets, which is cool; it should make life easier for this project. I took the bevy_audio interactive example and made two versions of it: interactive.rs which is the least intrusively changed but does now have a clone() that feels odd, and interactive_component.rs which relies on DspSources being used as assets and obviates the need for the dsp_manager. Neither feel perfect, but I feel like they'll give you a good means to discern the right direction for the project design-wise.
I haven't touched the docs or outward version numbers of bevy_fundsp itself.
Thanks for this cool project. I hope it continues to be updated.