Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big refactor for 0.2 #6

Merged
merged 57 commits into from
Nov 14, 2022
Merged

Big refactor for 0.2 #6

merged 57 commits into from
Nov 14, 2022

Conversation

harudagondi
Copy link
Owner

@harudagondi harudagondi commented Aug 29, 2022

Note

The first checklist group is only the necessary requirements to merge this PR.

The rest are not needed, but nice. It is better if the others are put in a separated PR.

Objective

Solution

Note for Users of this Branch

If you are a user of bevy_fundsp, please try to test this PR! This currently only works with bevy_audio (EDIT: and bevy_oddio!), because this relies on a branch I made on bevy.


Changelog

Reworked the majority of the code.

Added

  • A way to play streaming DSP sources. See SourceType::Dynamic.
  • You can play DSP sources using Audio::play_dsp.
  • Two iterators on streaming audio sources: Iter and IterMono.

Changed

  • Adding the DSP plugin.
    • You must now call DspPlugin::default().
  • The method on adding DSP sources.
    • No more initializing using DspAssets!
    • Just add your DSP function using app.add_dsp_source
  • Playing DSP sources require Audio to be mutable. (Use ResMut)
  • A lot of internals are shuffled around.

Removed

  • DspAssets
  • FnDspGraph
  • StreamingDspSource

@harudagondi harudagondi added enhancement New feature or request help wanted Extra attention is needed blocked this issue is blocked by other problems labels Aug 29, 2022
@harudagondi harudagondi added this to the 0.2 milestone Aug 29, 2022
@harudagondi harudagondi marked this pull request as ready for review November 14, 2022 04:53
@harudagondi harudagondi merged commit 7e1a63f into main Nov 14, 2022
@harudagondi harudagondi deleted the refactor-0.2 branch November 14, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked this issue is blocked by other problems enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for bevy_oddio
1 participant