-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big refactor for 0.2 #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harudagondi
added
enhancement
New feature or request
help wanted
Extra attention is needed
blocked
this issue is blocked by other problems
labels
Aug 29, 2022
3 tasks
DspControl has a lifetime, therefore it will not work with bevy_audio and kira
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
this issue is blocked by other problems
enhancement
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_audio
,Sync
requirement inDecodable::Decoder
bevyengine/bevy#5819needs to be merged first.is now merged! Now waiting for bevy 0.9.SoundData
NiklasEi/bevy_kira_audio#63 is blocking forkira
.oddio
Handle
or oddio'sControlled
inbevy_audio::Decodable
bevyengine/bevy#5828 needs to be resolved firstSoundData
NiklasEi/bevy_kira_audio#63 is blocking forkira
oddio
isn't even implemented yet for this PRDspGraph
bevy_oddio
#5Solution
bevy_audio
,blocked by [Merged by Bors] - RemoveNow waiting for bevy 0.9.Sync
requirement inDecodable::Decoder
bevyengine/bevy#5819bevy_kira_audio
,blocked by Expose several types NiklasEi/bevy_kira_audio#72Now waiting for bevy 0.9.bevy_oddio
bevy_audio
,blocked by [Merged by Bors] - RemoveSync
requirement inDecodable::Decoder
bevyengine/bevy#5819bevy_kira_audio
, blocked by Support playing sounds that implement kira'sSoundData
NiklasEi/bevy_kira_audio#63bevy_oddio
bevy_audio
, blocked by Add equivalent to kira'sHandle
or oddio'sControlled
inbevy_audio::Decodable
bevyengine/bevy#5828bevy_kira_audio
, blocked by Support playing sounds that implement kira'sSoundData
NiklasEi/bevy_kira_audio#63bevy_oddio
Note for Users of this Branch
If you are a user of
bevy_fundsp
, please try to test this PR! This currently only works with bevy_audio (EDIT: and bevy_oddio!), because this relies on a branch I made on bevy.Changelog
Reworked the majority of the code.
Added
SourceType::Dynamic
.Audio::play_dsp
.Iter
andIterMono
.Changed
DspPlugin::default()
.DspAssets
!app.add_dsp_source
Audio
to be mutable. (UseResMut
)Removed
DspAssets
FnDspGraph
StreamingDspSource