Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing press links for about page #61

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

tinykite
Copy link
Contributor

@tinykite tinykite commented Feb 8, 2024

What This Does

Adds 3 missing press links that appear on the current CAP website's about page — in the press section — but were missing from the cap static version. Because we only want to surface a subset of this full list of links, this also modifies the homepage and the cap-media-list component to make it possible to customize what media links the component displays on a case-by-case basis.

Screenshots

The homepage will continue to display only 5 links:
Screenshot 2024-02-08 at 1 25 34 PM

The press section of the about page will display the full press archive of links:
Screenshot 2024-02-08 at 1 25 47 PM

How To Test

I've discovered that the least-error prone way to check out a branch locally is to not follow the instructions github provides on each PR. It feels much more consistent to:

  • Add a new remote for my fork of capstone-stone, named meaningfully (for example, named tinykite)
  • Run git pull tinykite to make sure you have the latest remote branches
  • Run git checkout add-missing-press-links to checkout this branch

@tinykite tinykite marked this pull request as ready for review February 8, 2024 19:27
@tinykite tinykite requested a review from a team as a code owner February 8, 2024 19:27
@tinykite tinykite requested review from teovin and removed request for a team February 8, 2024 19:27
Copy link
Collaborator

@teovin teovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tinykite
Copy link
Contributor Author

Thanks Ebru!!

@tinykite tinykite merged commit aea0869 into harvard-lil:main Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants