Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Django #2028

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update Django #2028

merged 2 commits into from
Sep 5, 2023

Conversation

bensteinberg
Copy link
Contributor

@bensteinberg bensteinberg requested a review from a team as a code owner September 5, 2023 15:05
@bensteinberg bensteinberg requested review from matteocargnelutti and removed request for a team September 5, 2023 15:05
matteocargnelutti
matteocargnelutti approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@matteocargnelutti matteocargnelutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pending

@bensteinberg
Copy link
Contributor Author

Nodejs has changed how it issues packages; stay tuned for an additional commit. This is likely to pose a problem in other repos.

@bensteinberg
Copy link
Contributor Author

See https://github.com/nodesource/distributions#new-update-%EF%B8%8F and nodesource/distributions#1639

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (bea59df) 76.59% compared to head (5b7e6a5) 76.59%.
Report is 9 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2028   +/-   ##
========================================
  Coverage    76.59%   76.59%           
========================================
  Files           64       64           
  Lines         7066     7066           
========================================
  Hits          5412     5412           
  Misses        1654     1654

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bensteinberg bensteinberg merged commit 30ddf5b into harvard-lil:develop Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteocargnelutti matteocargnelutti matteocargnelutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bensteinberg @codecov-commenter @matteocargnelutti