Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiftool TIFF identification resolution #212

Closed
pwinckles opened this issue Jun 30, 2021 · 2 comments
Closed

exiftool TIFF identification resolution #212

pwinckles opened this issue Jun 30, 2021 · 2 comments

Comments

@pwinckles
Copy link
Contributor

I noticed that FITS is not reporting the PRONOM format id for our tiffs. At first I assumed it was because Droid was failing to identify the files, but this is not the case. The problem is that the exiftool format identification is suppressing the Droid identification.

The format as reported by Droid is Tagged Image File Format, and the format from exiftool is TIFF EXIF. Based on the format tree, the Droid identification is thrown out.

I dug into this further. The exiftool format is constructed here. What's interesting is that further down some of the formats that had EXIF appended to them are translated into something else. For example:

<xsl:when test="$format='PSD EXIF'">
	<xsl:value-of select="string('Adobe Photoshop')"/>
</xsl:when>

However, this is not done for TIFF EXIF. Is this intentional? Should there be an entry like:

<xsl:when test="$format='TIFF EXIF'">
	<xsl:value-of select="string('Tagged Image File Format')"/>
</xsl:when>

If not, what are your thoughts on changing the format resolution code to not throw out externalIdentifiers when resolving formats?

@pwinckles
Copy link
Contributor Author

pwinckles commented Aug 4, 2021

Okay, I believe I have identified the root cause of the issue:

  1. The exiftool xslt inappropriately adds EXIF to TIFFs that have a byte-order. It's unclear to me if this is appropriate for other formats, but it's certainly in correct for TIFFs
  2. JHOVE has a bug where it defaults the ExifVersion, so that all TIFFs are always identified as TIFF EXIF

@pwinckles
Copy link
Contributor Author

Resolved by #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant