Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10N: add the harvester-csi-driver-lvm description #1157

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Vicente-Cheng
Copy link

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6057

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need another PR to have harvester-csi-driver-lvm in addon page ?

@Vicente-Cheng
Copy link
Author

LGTM, do we need another PR to have harvester-csi-driver-lvm in addon page ?

No, the harvester-csi-driver-lvm will be the experimental addon (https://github.com/harvester/experimental-addons).
So, user needs to add it manually through the yaml file. The description is enough for it.

@a110605 a110605 merged commit f4d655c into harvester:master Sep 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants