Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark those unavailable addons on ARM64 #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

w13915984028
Copy link
Member

Problem:

Addon & repo chart version mis-matching (e.g. harvester/harvester#5840)
Add version matching check.

Solution:

Per comment harvester/harvester-installer#750 (comment), noticed we did not mark the addon on documents.

Signed-off-by: Jian Wang <jian.wang@suse.com>
@w13915984028
Copy link
Member Author

@bk201 @ibrokethecloud @jillian-maroket

Seems we did not add something about ARM64 supporting on the Harvester document. Any plans to add a separate chapter? thanks.

This PR is a minor update about those unavailable addons.

Copy link

github-actions bot commented Jul 4, 2024

Name Link
🔨 Latest commit 03b0e4f
😎 Deploy Preview https://66867024d49ccfb9f99b4aa1--harvester-preview.netlify.app

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"incompatible" seems more appropriate. I added "currently" because I assume that an ARM64-compatible package might be available in the future.

@@ -10,6 +10,8 @@ title: "PCI Devices"

_Available as of v1.1.0_

_Unavailable on ARM64 architecture_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Unavailable on ARM64 architecture_
_Currently incompatible with ARM64_

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have content like _Available as of v1.2.0_, I would prefer _Unavailable on ARM64 architecture_; maybe put them in same line is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Availability and compatibility are two different concepts. You can put them in the same line if you want, but I do not agree with using the draft wording.

@@ -10,6 +10,8 @@ title: "Seeder"

_Available as of v1.2.0_

_Unavailable on ARM64 architecture_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Unavailable on ARM64 architecture_
_Currently incompatible with ARM64_

@@ -10,6 +10,8 @@ title: "VM Import"

_Available as of v1.1.0_

_Unavailable on ARM64 architecture_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Unavailable on ARM64 architecture_
_Currently incompatible with ARM64_

@@ -10,6 +10,8 @@ title: "PCI Devices"

_Available as of v1.1.0_

_Unavailable on ARM64 architecture_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Unavailable on ARM64 architecture_
_Currently incompatible with ARM64_

@@ -10,6 +10,8 @@ title: "Seeder"

_Available as of v1.2.0_

_Unavailable on ARM64 architecture_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Unavailable on ARM64 architecture_
_Currently incompatible with ARM64_

@@ -10,6 +10,8 @@ title: "VM Import"

_Available as of v1.1.0_

_Unavailable on ARM64 architecture_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Unavailable on ARM64 architecture_
_Currently incompatible with ARM64_

@jillian-maroket
Copy link
Contributor

Seems we did not add something about ARM64 supporting on the Harvester document. Any plans to add a separate chapter?

I don't know if any of the engineers plan to create a PR for this. The only content I wrote for this feature is in the release notes:

ARM Support (Technical Preview)
You can install Harvester v1.3.0 on servers using ARM architecture. This is made possible by recent updates to KubeVirt and RKE2, key components of Harvester that now both support ARM64.

@bk201 What other information can we provide to customers?

@w13915984028
Copy link
Member Author

w13915984028 commented Jul 5, 2024

We may add a new chapter CPU Architecture under Installation or Advanced, it describes the already supported X86_64, and the experimental/tech-preview ARM64.

If no one is working on it, I will file another PR.

@ibrokethecloud
Copy link
Contributor

from an end user perspective the Harvester UX is same across both architectures.

the addons were not packaged in 1.3.0 due to time constraints. this should be addressed in 1.4.0 where all addons will be available for arm architecture as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants