-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usbdevice documentation #638
Conversation
|
76b00bf
to
f9a40f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more of a fan of not renaming the pci devices. But just adding a USB device section. The tech side looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you have concerns about the changes.
15f10af
to
06b60b3
Compare
Signed-off-by: Jack Yu <jack.yu@suse.com> Co-authored-by: Kiefer Chang <1691518+bk201@users.noreply.github.com> Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Related Issues
Three options
We have three options regarding the documentation structure. cc @bk201 @ibrokethecloud
Create a new folder called Device Management, and separate the PCI Devices and USB Devices.
Rename
PCI Device
toDevice Management
. Put all device content into it.(PR is this version) From Kiefer: Just adding a USB device section. Don't need to renaming the title.
The Add-on index pages is same as before because we haven't change the
pcidevices-controller
name