Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eventrouter to v0.1.1 and replace repo #545

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Bump eventrouter to v0.1.1 and replace repo #545

merged 1 commit into from
Jul 18, 2023

Conversation

chrisho
Copy link
Contributor

@chrisho chrisho commented Jul 18, 2023

@chrisho chrisho requested a review from guangbochen July 18, 2023 06:55
guangbochen
guangbochen approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

futuretea
futuretea approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@futuretea futuretea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bk201
bk201 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Verify with loki and can see events.

@bk201 bk201 merged commit 43b6740 into harvester:master Jul 18, 2023
4 checks passed
@bk201
Copy link
Member

bk201 commented Jul 18, 2023

@Mergifyio backport v1.2

@mergify
Copy link

mergify bot commented Jul 18, 2023 •
edited
Loading

backport v1.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 18, 2023
Merged
@w13915984028 w13915984028 mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@guangbochen guangbochen guangbochen approved these changes

@futuretea futuretea futuretea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisho @bk201 @guangbochen @futuretea