Validate containerd-registry setting #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Kuehl <connor.kuehl@suse.com>
FrankYang0529
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
LGTM, test with following steps and validation can work. Thank you.
- Use vagrant-pxe-harvester.
- Add following to config-create.yaml.j2.
systemSettings:
containerd-registry: '{"error json format"}'- Run
./setup_harvester.sh - The panel shows "could not parse containerd-registry as JSON".
|
@Mergifyio backport v1.2 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
harvester-installer allows nonsense values for containerd-registry in configuration.
Solution:
Deserialize the value to at least confirm the shape of the input string as a valid registries JSON object.
Related Issue: harvester/harvester#3295
Test plan: