Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO boot: do not set ttyS0 as console #574

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

bk201
Copy link
Member

@bk201 bk201 commented Oct 4, 2023

Some machines have a hard time booting with the parameter on.

Problem:

Some machines have a hard time booting with the parameter on.

Solution:

Remove the parameter. If the user needs it, he or she can add it manually in the GRUB menu.

Related Issue:
harvester/harvester#4586

Test plan:

  • Boot the ISO.
  • check console=ttyS0 isn't present in /proc/cmdline.

Some machines have a hard time booting with the parameter on.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Vicente-Cheng Vicente-Cheng merged commit 254b7c7 into harvester:master Oct 5, 2023
6 checks passed
@Vicente-Cheng
Copy link
Contributor

@Mergifyio backport v1.2

@mergify
Copy link

mergify bot commented Oct 5, 2023

backport v1.2

✅ Backports have been created

@bk201
Copy link
Member Author

bk201 commented Oct 11, 2023

@Mergifyio backport v1.1

@mergify
Copy link

mergify bot commented Oct 11, 2023

backport v1.1

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants