Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rancher to v2.8.1 and RKE2 to v1.26.12+rke2r1 (backport #605) #646

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 2, 2024

This is an automatic backport of pull request #605 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit 1c42f30)
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit 6fe0734)
@FrankYang0529 FrankYang0529 changed the title Bump Rancher to v2.7.9 and RKE2 to v1.26.11+rke2r1 (backport #605) Bump Rancher to v2.8.1 and RKE2 to v1.26.11+rke2r1 (backport #605) Feb 2, 2024
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bk201
Copy link
Member

bk201 commented Feb 4, 2024

@FrankYang0529 should we consider also use v1.26.12 or v1.26.13 (currently on rc3)?

@bk201
Copy link
Member

bk201 commented Feb 4, 2024

I tested the upgrade from v1.2.1, after the upgrade the system-upgrade-controller is gone (local-managed-system-upgrade-controller ManagedChart is gone).

Rancher keep complaining:

2024/02/04 15:21:17 [ERROR] error syncing 'fleet-local/local': handler monitor-system-upgrade-controller-readiness: unable to sync system upgrade controller status for [&TypeMeta{Kind:Clust
er,APIVersion:provisioning.cattle.io/v1,}] [fleet-local/local], status.FleetWorkspaceName was blank, requeuing

I did changed my local RKE2 version to v1.26.12+rke2r1, not sure if that's the reason.

@ibrokethecloud
Copy link
Contributor

@bk201 i assume the error is because rancherd is not initialised during the upgrade path? I can see the same error with v1.26.11+rke2r1

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we need the PR harvester/harvester#5103 to be merged and backported to v1.2 branch for the cluster.provisioning object to be successfully reconciled.

Signed-off-by: PoAn Yang <poan.yang@suse.com>
@FrankYang0529
Copy link
Member

@FrankYang0529 should we consider also use v1.26.12 or v1.26.13 (currently on rc3)?

I update v1.26.12. Thanks.

@FrankYang0529 FrankYang0529 changed the title Bump Rancher to v2.8.1 and RKE2 to v1.26.11+rke2r1 (backport #605) Bump Rancher to v2.8.1 and RKE2 to v1.26.12+rke2r1 (backport #605) Feb 5, 2024
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with harvester/harvester#5057
upgrade path from v1.2.1 -> v1.2-head (this PR) -> master-head

verified the VM can be migrated (w/o vlan due to harvester/harvester#5076)
And all basic operations work well.

@Vicente-Cheng Vicente-Cheng merged commit 9a8b3fe into v1.2 Feb 6, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/v1.2/pr-605 branch February 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants