bump monitoring charts shell version #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Optionally - if the harvester side supports it, this customization to use newer shell could extend to the embedded rancher too. Since rancher controls shell via a setting named |
|
@mallardduck Thanks very much. The harvester PR #766 has included your changes to solve CVE issues, and with more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
I'm on the O&B team that maintains shell and just looking to bump shell for CVE's we've addressed.
Unfamiliar with harvester stuff and this repo didn't have issues, so just made the PR myself; so something may be wrong.
Let me know if it needs changes.
If I follow correctly harvester uses Rancher 2.8.x currently, so the newest
v0.1.Xof shell should be the target; currently: https://github.com/rancher/shell/releases/tag/v0.1.26Solution:
Added new tag to image list, then bumped version in patches to use newer version.
Related Issue:
Test plan: