Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the usage of build ENV USE_LOCAL_IMAGES #828

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

w13915984028
Copy link
Member

Problem:

harvester/harvester#6489

Solution:

Allow specify a tag (e.g. for all 3 Harvester related images) via the ENV USE_LOCAL_IMAGES to skip the qualified images directly.

Related Issue:
harvester/harvester#6489

Test plan:

Signed-off-by: Jian Wang <jian.wang@suse.com>
@w13915984028
Copy link
Member Author

w13915984028 commented Sep 3, 2024

export USE_LOCAL_IMAGES=fix6486-head && make build-iso

the build log:

...
[ImageCache] docker.io/rancher/harvester-pcidevices:v0.4.0 exists.
[ImageCache] docker.io/rancher/harvester-seeder:v0.3.0 exists.
[ImageCache] docker.io/rancher/harvester-upgrade:fix6486-head meets the specified tag from USE_LOCAL_IMAGES.
[ImageCache] docker.io/rancher/harvester-upgrade:fix6486-head exists.
[ImageCache] docker.io/rancher/harvester-vm-import-controller:v0.4.0 exists.
[ImageCache] docker.io/rancher/harvester-webhook:fix6486-head meets the specified tag from USE_LOCAL_IMAGES.
[ImageCache] docker.io/rancher/harvester-webhook:fix6486-head exists.
[ImageCache] docker.io/rancher/harvester:fix6486-head meets the specified tag from USE_LOCAL_IMAGES.
[ImageCache] docker.io/rancher/harvester:fix6486-head exists.
[ImageCache] docker.io/rancher/support-bundle-kit:master-head has "-head" suffix.
[ImageCache] docker.io/rancher/support-bundle-kit:master-head: pulling...
master-head: Pulling from rancher/support-bundle-kit
Digest: sha256:c9464513d387e6acadc38144eec0758d5e6896e8678d543a2237594591bc1e4b
Status: Image is up to date for rancher/support-bundle-kit:master-head

With this extension, the following process is smooth:

(1) Git clone Harvester
(2) Checkout a new branch to add code and commit
(3) make && make package && make package-webhook && make package-upgrade";  3 images taged as `brancher-name-head` are available on local machine docker
(4) export USE_LOCAL_IMAGES=brancher-name-head
(5) make build-iso

This is useful for those changes which need to be validated via new ISO installation, e.g. change Harvester chart.

@w13915984028
Copy link
Member Author

@mergify backport v1.4

Copy link

mergify bot commented Sep 3, 2024

backport v1.4

✅ Backports have been created

Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

We'll need to also update the wiki page at https://github.com/harvester/harvester/wiki/Build-ISO-images once this is merged.

@bk201 bk201 merged commit cfd268f into harvester:master Sep 5, 2024
7 checks passed
@w13915984028
Copy link
Member Author

Neat!

We'll need to also update the wiki page at https://github.com/harvester/harvester/wiki/Build-ISO-images once this is merged.

@tserong

The wiki page https://github.com/harvester/harvester/wiki/Build-ISO-images is updated as well.

@tserong
Copy link
Contributor

tserong commented Sep 5, 2024

Thanks @w13915984028!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants