fine tune logic to filter disks

[ibrokethecloud]

Problem:

Logic disks managed by the raid controller will have the same serial number. This results in disks being deduplicated and ignored.

Solution:

From the sample data available the wwn is unique despite the serial number being the same.

The PR adds a minor tweak to continue comparing disks even if serial number is same and check for wwn uniqueness.

Related Issue:
harvester/harvester#6694
Test plan:

[tserong]

This hurts my brain a little bit, but LGTM :-)

[Vicente-Cheng]

lgtm, but I am curious about the actual case.
Could we have the udev info for devices with the same serial but a different WWN?

[ibrokethecloud]

seems to be easily reproducible when your disks are managed by a raid controller, and subsequent luns made available to the host. In this scenario as we have seen from our own testing the disk serial numbers are the same but wwn is different.

[Vicente-Cheng]

seems to be easily reproducible when your disks are managed by a raid controller, and subsequent luns made available to the host. In this scenario as we have seen from our own testing the disk serial numbers are the same but wwn is different.

Sure, I thought I could ask for this information with @irishgordo.
Just curious. I did not notice that I had used a similar raid card before.

Feel free to merge it : ))

[ibrokethecloud]

@Mergifyio backport v1.4

[mergify]

backport v1.4

✅ Backports have been created

• #862 fine tune logic to filter disks (backport #857) has been created for branch v1.4