Update VM IP after restore replace #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinsun
requested review from
lanfon72,
irishgordo,
TachunLin,
khushboo-rancher and
noahgildersleeve
lanfon72
reviewed
Aug 26, 2024
| endtime = datetime.now() + timedelta(seconds=wait_timeout) | ||
| while endtime > datetime.now(): | ||
| code, data = api_client.vms.get(unique_vm_name) | ||
| if 200 == code and "Running" == data.get('status', {}).get('printableStatus'): |
There was a problem hiding this comment.
I feel that we can implement wait_status_running as the wait_status_stopped does.
There was a problem hiding this comment.
Refactored in commit 58f5535.
khushboo-rancher
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1462
What this PR does / why we need it:
test_restore_replace_with_vm_shutdown_commanddue to VM IP is not update after restore place.Special notes for your reviewer:
n/a
Additional documentation or context
Before (
harvester-runtests/86)After (
harvester-runtests/89)