Add 'chosen:search_results_updated' event #1626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffee/chosen.proto.coffee
Outdated
| @@ -228,7 +228,10 @@ class @Chosen extends AbstractChosen | |||
| this.winnow_results() | |||
|
|
|||
| update_results_content: (content) -> | |||
| @search_results.update content | |||
| @search_results.html content | |||
| @form_field_jq.trigger("chosen:search_results_updated", {chosen: this}) | |||
There was a problem hiding this comment.
There is no such tink like @form_field_jq in the Prototype version (the _jq suffix stands for jQuery).
|
Sorry about those outdated diff errors. Fixed now. |
coffee/chosen.proto.coffee
Outdated
| @@ -229,6 +229,7 @@ class @Chosen extends AbstractChosen | |||
|
|
|||
| update_results_content: (content) -> | |||
| @search_results.update content | |||
| @form_field.trigger("chosen:search_results_updated", {chosen: this}) | |||
There was a problem hiding this comment.
The mehtod is .fire in Prototype, not .trigger
This event will be triggered on every update of the search results area (via `update_results_content()`). It can be used, for example, in case you need to attach extra info to your search result items.
|
I believe this has been discussed before and would've been a performance killer.. |
|
Closing, too old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This event will be triggered on every update of the search results
area (via
update_results_content()). It can be used, for example,in case you need to attach extra info to your search result items.