-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy license to build output directory. #2966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to add a license
property to the package.json
?
Gruntfile.coffee
Outdated
copy: | ||
main: | ||
files: [ | ||
{src: ['LICENSE.md'], dest: 'public/'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curly braces are not necessary here, and since we don't use them anywhere in the Gruntfile
I suggest we remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even better, use the simplified, single-file syntax;
copy:
main:
src: 'LICENSE.md'
dest: 'public/'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I didn’t catch that syntax in the docs. I’ll update momentarily!
Should we also update the package.json of the built package, to include the license file in the npm archive ? |
LICENSE (with any capitalization or extension) is automatically included in packages by npm — sorry, I should have mentioned that in the description (I had to look it up!):
|
then it is fine |
Also, adds a package-lock.json, since it seems like we haven’t touched the dependencies in a while.
16ac889
to
b0ac854
Compare
Force-pushed an updated commit with the Gruntfile modifications above. Thanks for the review! |
@harvesthq/chosen-developers to fix #2945.
This adds a step to the
build
grunt task which copiesLICENSE.md
to the output directory… which should theoretically include it in the final build? I’m not 100% sure, because build process is a little 🌁.Also, adds a
package-lock.json
, since it seems like we haven’t touched the dependencies in a while, and that’s a thing now.