Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the handling of ctrl key for multiple select #916

Merged
merged 1 commit into from
Dec 5, 2012

Conversation

stof
Copy link
Collaborator

@stof stof commented Nov 28, 2012

jQuery 1.7 is no longer emulating evt.metaKey based on evt.ctrlKey on
windows so the support of the ctrl key was not working anymore on windows.
And the Prototype version was also broken as this normalization was not
provided in this library.
Fixes #562

I allowed both the metaKey (not mapped on windows) and the ctrlKey on all platforms for simplicity.

@pfiller please review this.

jQuery 1.7 is no longer emulating evt.metaKey based on evt.ctrlKey on
windows so the support of the ctrl key was not working anymore on windows.
And the Prototype version was also broken as this normalization was not
provided in this library.
Fixes harvesthq#562
@pfiller
Copy link
Contributor

pfiller commented Nov 29, 2012

The code looks good to me, but what's up with those whitespace changes?

@stof
Copy link
Collaborator Author

stof commented Nov 29, 2012

My IDE is configured to strip trailing whitespaces automatically when saving files, as this is the rule in all other project where I contribute.
Do you prefer keeping trailing whitespaces as they are ? Btw, I already saw such changes in some other PR (or Pr adding some trailing whitespaces in other places)

@pfiller pfiller merged commit 5cc30f9 into harvesthq:master Dec 5, 2012
@pfiller
Copy link
Contributor

pfiller commented Dec 5, 2012

Thanks @stof. Let's send trailing whitespaces packing.

pfiller added a commit that referenced this pull request Dec 5, 2012
Includes these Pull Requests:

- #902 Fiexd Firefox mousedown drag issue
- #914 Handle select title
- #916 Fixed the handling of ctrl key for multiple select
- #920 Fixed multiple select placeholder clipping bug
- #929 Expose Chosen to the window object

Refer to these pull requests for details and diffs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl/command-click on multi select not working
2 participants