Using StateManager for JobApplication model #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
requested changes
Apr 2, 2018
hasjob/models/jobpost.py
Outdated
| def can_report(self): | ||
| return self.response in (EMPLOYER_RESPONSE.NEW, EMPLOYER_RESPONSE.PENDING, | ||
| EMPLOYER_RESPONSE.IGNORED, EMPLOYER_RESPONSE.REJECTED) | ||
| @response.transition(response.FLAGGED, response.NEW, title=__("Unflag"), message=__("This job application has been unflagged"), type='success') |
hasjob/views/listing.py
Outdated
| if job_application.response == EMPLOYER_RESPONSE.NEW: | ||
| job_application.response = EMPLOYER_RESPONSE.PENDING | ||
| if job_application.response.NEW: | ||
| job_application.mark_read() |
There was a problem hiding this comment.
This should be:
if job_application.mark_read.is_available:
job_application.mark_read()
hasjob/views/listing.py
Outdated
| # If the application is pending, mark it as opened. | ||
| # However, don't do this if the user is a siteadmin, unless they also own the post. | ||
| if post.admin_is(g.user) or not lastuser.has_permission('siteadmin'): | ||
| job_application.response = EMPLOYER_RESPONSE.PENDING | ||
| job_application.mark_read() |
added 2 commits
April 2, 2018 16:10
shreyas-satish
pushed a commit
that referenced
this pull request
Apr 11, 2018
* initial changes for state manager for job application * added transitions for application processing * more fixes * transition fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.