Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate tags for an unpacked section #22

Closed
hasherezade opened this issue Dec 2, 2018 · 1 comment
Closed

Do not generate tags for an unpacked section #22

hasherezade opened this issue Dec 2, 2018 · 1 comment
Assignees

Comments

@hasherezade
Copy link
Owner

Test case

How it is:

Currently, any modifications in sections are treated as patches. Hovewer, sometimes the modified section is not patched, but fully unpacked from the memory. Example:
Before:
before
After:
after
Currently, the content of such section is compared with an empty region. It generates a lot of noise, i.e.:
all_patches

How it should be

Sections that are fully unpacked in the memory should not be treated the same as patched. No tags should be generated for them, and they should be marked as unpacked.

@hasherezade
Copy link
Owner Author

Result

The code scan for the above test case, after the introduced changes:
code_scan
The same code scan can show also patches (if other code sections were patched), i.e.:
both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant