Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create random user name and password for haproxy #903

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • Created template function to create random proxy user name and password if do not exist
  • Use haproxy user name and password as global values so they can be used in both haproxy-cm.yaml and haproxy-deployment.yaml

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link

github-actions bot commented Jul 1, 2024

Unit Test Results

  26 files    26 suites   1m 0s ⏱️
109 tests 105 ✔️ 4 💤 0
110 runs  106 ✔️ 4 💤 0

Results for commit c7eab3c.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (3989abb) to head (c7eab3c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #903   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

Copy link

sonarcloud bot commented Jul 1, 2024

@JeffreyDallas JeffreyDallas merged commit 8ddc72a into main Jul 1, 2024
21 checks passed
@JeffreyDallas JeffreyDallas deleted the 00854-D-haproxy-user branch July 1, 2024 16:44
@jeromy-cannon
Copy link
Contributor

@JeffreyDallas , Looks like because the title started with 'ci:', it didn't trigger a new version. In the future, since this is code that is used in the charts build, it should probably either be 'fix:' or 'feat:' so that it upgrades the version and publishes a build.

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network]: update the haproxy-dataplaneapi userid and password to use k8s secrets
3 participants