Update workers on docker-compose.yml #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfwolker
force-pushed
the
fix/workers-cold-start-dc
branch
from
149936c
to
64efc6f
Compare
|
Hi @wolfwolker , I can see that the docker-compose.yml file has been changed but there are other docker-compose*.yml files which should also be updated? |
on cold start of docker compose workers crashes because ipfs is not ready yet. With this the workers wait til the ipfs sevice is READY Signed-off-by: noel garcia <noel.garcia@intellecteu.com>
Signed-off-by: noel garcia <noel.garcia@intellecteu.com>
Signed-off-by: noel garcia <noel.garcia@intellecteu.com>
Signed-off-by: noel garcia <noel.garcia@intellecteu.com>
wolfwolker
force-pushed
the
fix/workers-cold-start-dc
branch
from
2fed5f8
to
6b0ebb4
Compare
|
you're right @simvalery. Just updated the other compose files |
simvalery
approved these changes
Jul 12, 2023
felipeneuhauss
pushed a commit
to IntellectEU/guardian
that referenced
this pull request
Jul 22, 2023
…tart-dc Update workers on docker-compose.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On cold start of docker compose, workers crash because ipfs is not ready yet. With this change the workers will wait til the ipfs sevice is READY based on the container health check.
Related issue(s):
I haven't found any related open issue, but this behaviour is happening when using ipfs container.
Steps to reproduce the issue:
After the fix
After the fix, even on the first compose up, the workers don't crash