remove unnecessary exception translation

Signed-off-by: Luke Lee <luke.lee@hashgraph.com>
hashgraph · Dec 24, 2024 · 935d655 · 935d655
1 parent bfbdf1e
commit 935d655
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/.../app/service/contract/impl/exec/systemcontracts/hts/transfer/ClassicTransfersDecoder.java b/.../app/service/contract/impl/exec/systemcontracts/hts/transfer/ClassicTransfersDecoder.java
@@ -317,14 +317,10 @@ private void consolidateInto(
     }
 
     private AccountAmount mergeAdjusts(@NonNull final AccountAmount from, @NonNull final AccountAmount to) {
-        try {
-            return from.copyBuilder()
-                    .amount(Math.addExact(from.amount(), to.amount()))
-                    .isApproval(from.isApproval() || to.isApproval())
-                    .build();
-        } catch (ArithmeticException e) {
-            throw new IllegalArgumentException("Amount overflow when merging account amounts");
-        }
+        return from.copyBuilder()
+                .amount(Math.addExact(from.amount(), to.amount()))
+                .isApproval(from.isApproval() || to.isApproval())
+                .build();
     }
 
     private List<NftTransfer> mergeNftTransfers(

diff --git a/...ice/contract/impl/test/exec/systemcontracts/hts/transfer/ClassicTransfersDecoderTest.java b/...ice/contract/impl/test/exec/systemcontracts/hts/transfer/ClassicTransfersDecoderTest.java
@@ -131,8 +131,7 @@ void decodeCryptoTransferOverflow() {
                         .build(),
                 EMPTY_TUPLE_ARRAY);
         Assertions.assertThatThrownBy(() -> subject.decodeCryptoTransferV2(encodedInput.array(), converter))
-                .isInstanceOf(IllegalArgumentException.class)
-                .hasMessage("Amount overflow when merging account amounts");
+                .isInstanceOf(ArithmeticException.class);
     }
 
     @Test
@@ -153,8 +152,7 @@ void decodeCryptoTokenTransferOverflow() {
                                         .build())
                         .build());
         Assertions.assertThatThrownBy(() -> subject.decodeCryptoTransferV2(encodedInput.array(), converter))
-                .isInstanceOf(IllegalArgumentException.class)
-                .hasMessage("Amount overflow when merging account amounts");
+                .isInstanceOf(ArithmeticException.class);
     }
 
     private static List<AccountAmount> unwrapTokenAmounts(final TransactionBody body) {