chore: Add code coverage to `CustomRoyaltyFeeAssessor`, `CustomFixedFeeAssessor` #13224

Neeharika-Sompalli · 2024-05-11T19:06:38Z

Fixes #13163
Fixes #13212

Add code coverage to CustomRoyaltyFeeAssessor, CustomFixedFeeAssessor

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

github-actions · 2024-05-11T19:24:42Z

Node: HAPI Test (Restart) Results

2 tests 0 ✅ 6m 58s ⏱️
2 suites 0 💤
2 files 2 ❌

For more details on these failures, see this check.

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T19:26:02Z

Node: HAPI Test (Node Death Reconnect) Results

2 tests 2 ✅ 8m 49s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T19:36:11Z

Node: HAPI Test (Token) Results

235 tests 233 ✅ 21m 12s ⏱️
17 suites 2 💤
17 files 0 ❌

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T19:51:09Z

Node: HAPI Test (Misc) Results

464 tests 453 ✅ 42m 19s ⏱️
77 suites 10 💤
77 files 1 ❌

For more details on these failures, see this check.

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T19:53:18Z

Node: HAPI Test (Crypto) Results

335 tests 335 ✅ 41m 41s ⏱️
25 suites 0 💤
25 files 0 ❌

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T20:10:58Z

Node: Unit Test Results

2 304 files + 2 2 304 suites +2 3h 47m 24s ⏱️ + 11m 47s
118 926 tests +13 118 859 ✅ +13 67 💤 ±0 0 ❌ ±0
127 487 runs +13 127 420 ✅ +13 67 💤 ±0 0 ❌ ±0

Results for commit 8b1e61d. ± Comparison against base commit ea0b875.

This pull request removes 3997 and adds 3773 tests. Note that renamed tests count towards both.


  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@d6cf6b4a
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@115b2898
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@bfe32425
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@a59b7da9
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@faf314f8
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@78c2c590
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5463f976
…

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T20:11:27Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✅ 54m 36s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-11T20:25:19Z

Node: HAPI Test (Smart Contract) Results

592 tests 591 ✅ 1h 12m 19s ⏱️
63 suites 0 💤
63 files 1 ❌

For more details on these failures, see this check.

Results for commit 8b1e61d.

♻️ This comment has been updated with latest results.

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

thomas-swirlds-labs

LGTM! @Neeharika-Sompalli 👍

...m/hedera/node/app/service/token/impl/test/handlers/transfer/CustomFeeAssessmentStepTest.java

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

thomas-swirlds-labs

LGTM! 👍

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

…eeAssessor` (#13224) Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>

Neeharika-Sompalli added 2 commits May 11, 2024 13:39

add codecoverage

465f166

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

add code coverage

ba21efb

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

add code coverage

b8402b3

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli changed the title ~~Add code coverage to CustomRoyaltyFeeAssessor~~ core: Add code coverage to CustomRoyaltyFeeAssessor, CustomFixedFeeAssessor May 11, 2024

Neeharika-Sompalli changed the title ~~core: Add code coverage to CustomRoyaltyFeeAssessor, CustomFixedFeeAssessor~~ chore: Add code coverage to CustomRoyaltyFeeAssessor, CustomFixedFeeAssessor May 11, 2024

add code coverage

0695a2c

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli marked this pull request as ready for review May 11, 2024 23:49

Neeharika-Sompalli requested a review from a team May 11, 2024 23:49

Neeharika-Sompalli requested a review from a team as a code owner May 11, 2024 23:49

Neeharika-Sompalli requested a review from netopyr May 11, 2024 23:49

thomas-swirlds-labs previously approved these changes May 13, 2024

View reviewed changes

...m/hedera/node/app/service/token/impl/test/handlers/transfer/CustomFeeAssessmentStepTest.java Outdated Show resolved Hide resolved

revert not needed changes

249f840

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli dismissed thomas-swirlds-labs’s stale review via 249f840 May 13, 2024 14:10

Neeharika-Sompalli requested a review from thomas-swirlds-labs May 13, 2024 14:10

thomas-swirlds-labs previously approved these changes May 13, 2024

View reviewed changes

add more tests

bdf038d

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli dismissed thomas-swirlds-labs’s stale review via bdf038d May 13, 2024 15:01

add more tests

dc0e1a6

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

Neeharika-Sompalli requested a review from thomas-swirlds-labs May 13, 2024 15:41

Neeharika-Sompalli added 3 commits May 13, 2024 13:32

fix tests

70a9f4c

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

fix tests

5a44411

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

fix tests

b41a801

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>

thomas-swirlds-labs approved these changes May 14, 2024

View reviewed changes

Merge branch 'develop' into 13162-D-codecov

8b1e61d

Neeharika-Sompalli merged commit 40b6658 into develop May 14, 2024
37 of 43 checks passed

Neeharika-Sompalli deleted the 13162-D-codecov branch May 14, 2024 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add code coverage to `CustomRoyaltyFeeAssessor`, `CustomFixedFeeAssessor` #13224

chore: Add code coverage to `CustomRoyaltyFeeAssessor`, `CustomFixedFeeAssessor` #13224

Neeharika-Sompalli commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

thomas-swirlds-labs left a comment

thomas-swirlds-labs left a comment

chore: Add code coverage to CustomRoyaltyFeeAssessor, CustomFixedFeeAssessor #13224

chore: Add code coverage to CustomRoyaltyFeeAssessor, CustomFixedFeeAssessor #13224

Conversation

Neeharika-Sompalli commented May 11, 2024 • edited Loading

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented May 11, 2024 • edited Loading

Node: Unit Test Results

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented May 11, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

chore: Add code coverage to `CustomRoyaltyFeeAssessor`, `CustomFixedFeeAssessor` #13224

chore: Add code coverage to `CustomRoyaltyFeeAssessor`, `CustomFixedFeeAssessor` #13224

Neeharika-Sompalli commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading

github-actions bot commented May 11, 2024 •

edited

Loading