Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase coverage in CustomFeeExemptions #13233

Merged
merged 6 commits into from
May 15, 2024

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:

Adding new unit test cases to increase coverage for CustomFeeExemptions to 100%

Related issue(s):

Fixes #13141

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
@thomas-swirlds-labs thomas-swirlds-labs requested a review from a team May 13, 2024 13:50
@thomas-swirlds-labs thomas-swirlds-labs requested a review from a team as a code owner May 13, 2024 13:50
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

@thomas-swirlds-labs thomas-swirlds-labs self-assigned this May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  8m 3s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  8m 46s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Token) Results

235 tests   233 ✅  21m 19s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  40m 39s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Misc) Results

464 tests   453 ✅  44m 0s ⏱️
 77 suites   10 💤
 77 files      1 ❌

For more details on these failures, see this check.

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 35s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: HAPI Test (Smart Contract) Results

592 tests   592 ✅  1h 12m 24s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit d61a674.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Node: Unit Test Results

  2 306 files  +1    2 306 suites  +1   3h 28m 4s ⏱️ + 46m 28s
118 966 tests +8  118 899 ✅ +8  67 💤 ±0  0 ❌ ±0 
127 527 runs  +8  127 460 ✅ +8  67 💤 ±0  0 ❌ ±0 

Results for commit d61a674. ± Comparison against base commit e64faab.

This pull request removes 4023 and adds 3794 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6d1174bb
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@65da6790
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@3ca20981
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6b864431
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@396d850
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@c2782b56
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@22b87852
…

♻️ This comment has been updated with latest results.

Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cases to consider! LGTM

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (e64faab) to head (d61a674).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #13233   +/-   ##
==========================================
  Coverage      61.73%   61.74%           
- Complexity     31227    31230    +3     
==========================================
  Files           3442     3442           
  Lines         141267   141267           
  Branches       14778    14780    +2     
==========================================
+ Hits           87217    87226    +9     
+ Misses         50163    50156    -7     
+ Partials        3887     3885    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-swirlds-labs thomas-swirlds-labs merged commit 5218612 into develop May 15, 2024
45 of 47 checks passed
@thomas-swirlds-labs thomas-swirlds-labs deleted the 13141-cover-CustomFeeExemptions branch May 15, 2024 11:09
bilyana-gospodinova pushed a commit that referenced this pull request Jun 13, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomFeeExemptions [35.71 %]
3 participants