-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Increase coverage in CustomFeeExemptions #13233
Conversation
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM TY
Node: HAPI Test (Restart) Results2 tests 2 ✅ 8m 3s ⏱️ Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results2 tests 2 ✅ 8m 46s ⏱️ Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results235 tests 233 ✅ 21m 19s ⏱️ Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results335 tests 335 ✅ 40m 39s ⏱️ Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results464 tests 453 ✅ 44m 0s ⏱️ For more details on these failures, see this check. Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results21 tests 21 ✅ 54m 35s ⏱️ Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results592 tests 592 ✅ 1h 12m 24s ⏱️ Results for commit d61a674. ♻️ This comment has been updated with latest results. |
Node: Unit Test Results 2 306 files +1 2 306 suites +1 3h 28m 4s ⏱️ + 46m 28s Results for commit d61a674. ± Comparison against base commit e64faab. This pull request removes 4023 and adds 3794 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cases to consider! LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13233 +/- ##
==========================================
Coverage 61.73% 61.74%
- Complexity 31227 31230 +3
==========================================
Files 3442 3442
Lines 141267 141267
Branches 14778 14780 +2
==========================================
+ Hits 87217 87226 +9
+ Misses 50163 50156 -7
+ Partials 3887 3885 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com> Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Description:
Adding new unit test cases to increase coverage for CustomFeeExemptions to 100%
Related issue(s):
Fixes #13141