Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: FileAppendHandler unit test coverage #13256

Merged
merged 1 commit into from
May 14, 2024

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented May 13, 2024

Description:
Improve unit test coverage for FileAppendHandler class

Related issue(s):

Fixes #13188

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor self-assigned this May 13, 2024
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 53s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 1b27ec1.

Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  9m 8s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 1b27ec1.

Copy link

Node: HAPI Test (Token) Results

235 tests   233 ✅  19m 14s ⏱️
 17 suites    2 💤
 17 files      0 ❌

Results for commit 1b27ec1.

Copy link

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  35m 47s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 1b27ec1.

Copy link

Node: HAPI Test (Misc) Results

459 tests   449 ✅  39m 9s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 1b27ec1.

Copy link

Node: Unit Test Results

  2 286 files  ±0    2 286 suites  ±0   2h 39m 47s ⏱️ - 38m 45s
118 847 tests +3  118 780 ✅ +3  67 💤 ±0  0 ❌ ±0 
127 335 runs  +3  127 268 ✅ +3  67 💤 ±0  0 ❌ ±0 

Results for commit 1b27ec1. ± Comparison against base commit 1722fef.

This pull request removes 4037 and adds 3804 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=11282,hostnameExternal=187.245.70.189,portExternalIpv4=58655,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@5357bed9,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@3fdb9eb9,memo=g75T9ArskB],
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ Fails handle if keys doesn't exist on file to be appended
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ Pre handle works as expected
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ Pre handle works as expected immutable
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ appliesNewContent()
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ appliesUpgradeFileNewContent()
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ calculateFeesHappyPath()
com.hedera.node.app.service.file.impl.test.handlers.FileAppendHandlerTest ‑ handleRejectsMissingFile()
…

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 2s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 1b27ec1.

Copy link

github-actions bot commented May 14, 2024

Node: HAPI Test (Smart Contract) Results

592 tests   591 ✅  1h 7m 21s ⏱️
 63 suites    0 💤
 63 files      1 ❌

For more details on these failures, see this check.

Results for commit 1b27ec1.

♻️ This comment has been updated with latest results.

@kimbor kimbor marked this pull request as ready for review May 14, 2024 05:03
@kimbor kimbor requested a review from a team May 14, 2024 05:03
@kimbor kimbor requested a review from a team as a code owner May 14, 2024 05:03
@kimbor kimbor requested review from rbair23 and povolev15 May 14, 2024 05:03
@kimbor kimbor merged commit d3ec57a into develop May 14, 2024
47 of 50 checks passed
@kimbor kimbor deleted the 13188-FileAppendHandler-test-coverage branch May 14, 2024 19:10
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileAppendHandler [58 %]
3 participants