Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cherry-pick: Enable tokens.balancesInQueries.enabled #13718

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix: Cherry-pick: Enable tokens.balancesInQueries.enabled #13718

merged 2 commits into from
Jun 6, 2024

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Jun 6, 2024

Description:

This PR updates the configuration to enable balances in queries.
It also updates the application.properties file with the changes that were done for the 0.49 release.

Related issue(s):

Fixes #13715

@netopyr
Enable tokens.balancesInQueries.enabled
005cb9b 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
(cherry picked from commit ad8fdba)
@netopyr netopyr added this to the v0.51 milestone Jun 6, 2024
@netopyr netopyr self-assigned this Jun 6, 2024
@netopyr netopyr requested a review from a team June 6, 2024 17:43
@netopyr netopyr requested a review from a team as a code owner June 6, 2024 17:43
@netopyr netopyr requested a review from kimbor June 6, 2024 17:43
iwsimon
iwsimon previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kimbor
kimbor previously approved these changes Jun 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: Unit Test Results

  2 319 files  ±0    2 319 suites  ±0   3h 31m 33s ⏱️ -13s
112 676 tests ±0  112 607 ✅ ±0  69 💤 ±0  0 ❌ ±0 
121 187 runs  ±0  121 118 ✅ ±0  69 💤 ±0  0 ❌ ±0 

Results for commit e9e8bfb. ± Comparison against base commit 4fa87b3.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

3 tests   3 ✅  5m 54s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 58s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

 20 files   20 suites   6m 22s ⏱️
257 tests 257 ✅ 0 💤 0 ❌
260 runs  260 ✅ 0 💤 0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Jun 6, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

 23 files   23 suites   11m 47s ⏱️
350 tests 350 ✅ 0 💤 0 ❌
356 runs  356 ✅ 0 💤 0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 20s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

 51 files   51 suites   24m 2s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
374 runs  374 ✅ 0 💤 0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

 68 files   68 suites   24m 41s ⏱️
609 tests 609 ✅ 0 💤 0 ❌
637 runs  637 ✅ 0 💤 0 ❌

Results for commit e9e8bfb.

♻️ This comment has been updated with latest results.

@netopyr
Fix unit test
e9e8bfb 
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
@netopyr netopyr dismissed stale reviews from Nana-EC, kimbor, and iwsimon via e9e8bfb June 6, 2024 18:29
@netopyr netopyr requested review from Nana-EC and kimbor June 6, 2024 18:44
@netopyr netopyr requested a review from iwsimon June 6, 2024 18:44
iwsimon
iwsimon approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwsimon iwsimon merged commit d108b6d into release/0.51 Jun 6, 2024
54 checks passed
@iwsimon iwsimon deleted the 13715-enable-balancesInQueries-051 branch June 6, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwsimon iwsimon iwsimon approved these changes

@rbair23 rbair23 rbair23 approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner

@poulok poulok Awaiting requested review from poulok poulok is a code owner

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan is a code owner

@steven-sheehy steven-sheehy Awaiting requested review from steven-sheehy steven-sheehy is a code owner

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC Nana-EC is a code owner

@kimbor kimbor Awaiting requested review from kimbor

Assignees

@netopyr netopyr

Labels
None yet
Projects
None yet
Milestone
v0.51
Development

Successfully merging this pull request may close these issues.
5 participants
@netopyr @kimbor @rbair23 @Nana-EC @iwsimon