-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: servicedefinition tests #13731
Conversation
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…ules because CI was failing Dependency (Module Info) check. Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Node: HAPI Test (Token) Results 20 files 20 suites 5m 57s ⏱️ Results for commit c870a34. |
Node: HAPI Test (Restart) Results3 tests 3 ✅ 6m 6s ⏱️ Results for commit c870a34. |
Node: HAPI Test (Time Consuming) Results19 tests 19 ✅ 21m 57s ⏱️ Results for commit c870a34. |
Node: HAPI Test (Smart Contract) Results 71 files 71 suites 23m 42s ⏱️ Results for commit c870a34. |
Node: HAPI Test (Crypto) Results 23 files 23 suites 12m 0s ⏱️ Results for commit c870a34. |
Node: HAPI Test (Node Death Reconnect) Results3 tests 3 ✅ 5m 46s ⏱️ Results for commit c870a34. |
Node: Unit Test Results 2 338 files + 7 2 338 suites +7 2h 26m 49s ⏱️ +6s Results for commit c870a34. ± Comparison against base commit eb1e40c. This pull request removes 370 and adds 139 tests. Note that renamed tests count towards both.
|
Node: HAPI Test (Misc) Results 51 files 51 suites 23m 43s ⏱️ Results for commit c870a34. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @kimbor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @kimbor :)
Description:
Add test coverage for the non-impl service modules:
hedera-schedule-service already had tests set up.
Related issue(s):
Fixes #13724
Fixes #13729
Fixes #13728
Fixes #13727
Fixes #13725
Fixes #13726
Fixes #13288