Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: servicedefinition tests #13731

Merged
merged 3 commits into from
Jun 7, 2024
Merged

feat: servicedefinition tests #13731

merged 3 commits into from
Jun 7, 2024

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Jun 6, 2024

Description:
Add test coverage for the non-impl service modules:

  • hedera-consensus-service
  • hedera-file-service
  • hedera-network-admin-service
  • hedera-token-service
  • hedera-util-service

hedera-schedule-service already had tests set up.

Related issue(s):

Fixes #13724
Fixes #13729
Fixes #13728
Fixes #13727
Fixes #13725
Fixes #13726
Fixes #13288

kimbor added 2 commits June 6, 2024 16:39
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor self-assigned this Jun 6, 2024
@kimbor kimbor added this to the v0.52 milestone Jun 6, 2024
…ules because CI was failing Dependency (Module Info) check.

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Token) Results

 20 files   20 suites   5m 57s ⏱️
268 tests 268 ✅ 0 💤 0 ❌
343 runs  343 ✅ 0 💤 0 ❌

Results for commit c870a34.

Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Restart) Results

3 tests   3 ✅  6m 6s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit c870a34.

Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  21m 57s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit c870a34.

Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Smart Contract) Results

 71 files   71 suites   23m 42s ⏱️
604 tests 604 ✅ 0 💤 0 ❌
656 runs  656 ✅ 0 💤 0 ❌

Results for commit c870a34.

Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Crypto) Results

 23 files   23 suites   12m 0s ⏱️
350 tests 350 ✅ 0 💤 0 ❌
356 runs  356 ✅ 0 💤 0 ❌

Results for commit c870a34.

Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 46s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit c870a34.

Copy link

github-actions bot commented Jun 7, 2024

Node: Unit Test Results

  2 338 files  + 7    2 338 suites  +7   2h 26m 49s ⏱️ +6s
119 786 tests +14  119 716 ✅ +14  70 💤 ±0  0 ❌ ±0 
128 353 runs  +14  128 283 ✅ +14  70 💤 ±0  0 ❌ ±0 

Results for commit c870a34. ± Comparison against base commit eb1e40c.

This pull request removes 370 and adds 139 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.consensus.ConsensusServiceDefinitionTest ‑ checkBasePath()
com.hedera.node.app.service.consensus.ConsensusServiceDefinitionTest ‑ methodsDefined()
com.hedera.node.app.service.file.FileServiceDefinitionTest ‑ checkBasePath()
com.hedera.node.app.service.file.FileServiceDefinitionTest ‑ methodsDefined()
com.hedera.node.app.service.networkadmin.FreezeServiceDefinitionTest ‑ checkBasePath()
com.hedera.node.app.service.networkadmin.FreezeServiceDefinitionTest ‑ methodsDefined()
com.hedera.node.app.service.networkadmin.NetworkServiceDefinitionTest ‑ checkBasePath()
…

Copy link

github-actions bot commented Jun 7, 2024

Node: HAPI Test (Misc) Results

 51 files   51 suites   23m 43s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
374 runs  374 ✅ 0 💤 0 ❌

Results for commit c870a34.

@kimbor kimbor marked this pull request as ready for review June 7, 2024 01:14
@kimbor kimbor requested review from a team as code owners June 7, 2024 01:14
@kimbor kimbor requested a review from a team June 7, 2024 01:14
@kimbor kimbor requested a review from a team as a code owner June 7, 2024 01:14
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @kimbor

Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kimbor :)

@kimbor kimbor merged commit d0bce98 into develop Jun 7, 2024
72 of 73 checks passed
@kimbor kimbor deleted the 13724-servicedefinition-tests branch June 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants