Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase code coverage in CryptoDeleteHandlerTest #16832

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Nov 28, 2024

Description:
Code coverage increased from 77.78 % to 94.44 %

Related issue(s):

Fixes #16831

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze added this to the v0.58 milestone Nov 28, 2024
@petreze petreze self-assigned this Nov 28, 2024
@petreze petreze requested a review from a team as a code owner November 28, 2024 13:12
@petreze petreze requested a review from iwsimon November 28, 2024 13:12
Copy link

codacy-production bot commented Nov 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (539f059) 97548 63701 65.30%
Head commit (966a5b1) 97548 (+0) 63707 (+6) 65.31% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16832) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (539f059) to head (966a5b1).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16832   +/-   ##
==========================================
  Coverage      63.60%   63.60%           
- Complexity     20401    20402    +1     
==========================================
  Files           2537     2537           
  Lines          94783    94783           
  Branches        9907     9907           
==========================================
+ Hits           60285    60291    +6     
+ Misses         30892    30886    -6     
  Partials        3606     3606           

see 1 file with indirect coverage changes

Impacted file tree graph

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze changed the title test: add test for calculateFees method in CryptoDeleteHandler test: Increase code coverage in CryptoDeleteHandlerTest Nov 28, 2024
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! @petreze

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze merged commit b8f0637 into develop Nov 29, 2024
53 checks passed
@petreze petreze deleted the 16831-codecov-crypto-delete-handler branch November 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage for CryptoDeleteHandler from [77.78 %]
2 participants