Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase code coverage in AssociateTokenRecipientsStep #16927

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Dec 5, 2024

Description:
Code coverage increased from 73.97 % to 93.62 %

Related issue(s):

Fixes #16926

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze requested a review from a team as a code owner December 5, 2024 08:54
@petreze petreze requested a review from mhess-swl December 5, 2024 08:54
@petreze petreze self-assigned this Dec 5, 2024
@petreze petreze added this to the v0.58 milestone Dec 5, 2024
Copy link

codacy-production bot commented Dec 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1b7439f) 97954 64201 65.54%
Head commit (b8d0dd7) 97954 (+0) 64219 (+18) 65.56% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16927) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (1b7439f) to head (b8d0dd7).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16927      +/-   ##
=============================================
+ Coverage      63.86%   63.88%   +0.02%     
- Complexity     20575    20585      +10     
=============================================
  Files           2540     2540              
  Lines          95189    95189              
  Branches        9944     9944              
=============================================
+ Hits           60790    60813      +23     
+ Misses         30798    30779      -19     
+ Partials        3601     3597       -4     

see 11 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze merged commit c7e75c3 into develop Dec 5, 2024
51 of 52 checks passed
@petreze petreze deleted the 16926-code-cov-associate-token-rec branch December 5, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code coverage in AssociateTokenRecipientsStep from [73.97 %]
2 participants