Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Roll hiero gradle conventions to version 0.1.4 (#17149) #17156

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

andrewb1269hg
Copy link
Contributor

Description:

Cherry-pick the version roll of gradle build conventions to version 0.1.4.

Related issue(s):

Fixes #17148

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
@andrewb1269hg andrewb1269hg requested review from a team as code owners December 21, 2024 03:53
@andrewb1269hg andrewb1269hg changed the base branch from develop to release/0.58 December 21, 2024 03:54
@andrewb1269hg andrewb1269hg added this to the v0.58 milestone Dec 21, 2024
@andrewb1269hg andrewb1269hg self-assigned this Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (aee0358) to head (c360121).
Report is 2 commits behind head on release/0.58.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.58   #17156      +/-   ##
==================================================
+ Coverage           64.26%   64.27%   +0.01%     
- Complexity          20882    20885       +3     
==================================================
  Files                2549     2549              
  Lines               95985    95976       -9     
  Branches            10044    10043       -1     
==================================================
+ Hits                61683    61690       +7     
+ Misses              30673    30656      -17     
- Partials             3629     3630       +1     

see 20 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aee0358) 95748 65121 68.01%
Head commit (c360121) 95739 (-9) 65129 (+8) 68.03% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17156) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@alex-kuzmin-hg alex-kuzmin-hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@Nana-EC Nana-EC merged commit 32645d1 into release/0.58 Dec 26, 2024
50 of 61 checks passed
@Nana-EC Nana-EC deleted the update-gradle-build-version branch December 26, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Publishing Issue with Gradle Conventions
5 participants