Reduce the overall noise from warnings and remove obsolete code

Signed-off-by: instamenta <instamenta@abv.bg>
hashgraph · Sep 20, 2024 · 1c03881 · 1c03881
1 parent f52d111
commit 1c03881
Show file tree

Hide file tree

Showing 27 changed files with 186 additions and 165 deletions.
diff --git a/src/commands/account.mjs b/src/commands/account.mjs
@@ -27,7 +27,7 @@ import { FREEZE_ADMIN_ACCOUNT } from '../core/constants.mjs'
 
 export class AccountCommand extends BaseCommand {
   /**
-   * @param {{accountManager: AccountManager, logger: Logger, helm: Helm, k8: K8, chartManager: ChartManager, configManager: ConfigManager, depManager: DependencyManager}} opts
+   * @param {{accountManager: AccountManager, logger: SoloLogger, helm: Helm, k8: K8, chartManager: ChartManager, configManager: ConfigManager, depManager: DependencyManager}} opts
    * @param {number[][]} [systemAccounts]
    */
   constructor (opts, systemAccounts = constants.SYSTEM_ACCOUNTS) {
@@ -359,21 +359,21 @@ export class AccountCommand extends BaseCommand {
       },
       {
         title: 'get the account info',
-        task: async (ctx, task) => {
+        task: async (ctx) => {
           ctx.accountInfo = await self.buildAccountInfo(await self.getAccountInfo(ctx), ctx.config.namespace, ctx.config.privateKey)
         }
       },
       {
         title: 'update the account',
-        task: async (ctx, task) => {
+        task: async (ctx) => {
           if (!(await self.updateAccountInfo(ctx))) {
             throw new FullstackTestingError(`An error occurred updating account ${ctx.accountInfo.accountId}`)
           }
         }
       },
       {
         title: 'get the updated account info',
-        task: async (ctx, task) => {
+        task: async (ctx) => {
           self.accountInfo = await self.buildAccountInfo(await self.getAccountInfo(ctx), ctx.config.namespace, false)
           this.logger.showJSON('account info', self.accountInfo)
         }
@@ -430,7 +430,7 @@ export class AccountCommand extends BaseCommand {
       },
       {
         title: 'get the account info',
-        task: async (ctx, task) => {
+        task: async (ctx) => {
           self.accountInfo = await self.buildAccountInfo(await self.getAccountInfo(ctx), ctx.config.namespace, false)
           this.logger.showJSON('account info', self.accountInfo)
         }

diff --git a/src/commands/base.mjs b/src/commands/base.mjs
@@ -57,10 +57,10 @@ export class BaseCommand extends ShellRunner {
   }
 
   /**
-   * @param {{logger: Logger, helm: Helm, k8: K8, chartManager: ChartManager, configManager: ConfigManager, depManager: DependencyManager}} opts
+   * @param {{logger: SoloLogger, helm: Helm, k8: K8, chartManager: ChartManager, configManager: ConfigManager, depManager: DependencyManager}} opts
    */
   constructor (opts) {
-    if (!opts || !opts.logger) throw new Error('An instance of core/Logger is required')
+    if (!opts || !opts.logger) throw new Error('An instance of core/SoloLogger is required')
     if (!opts || !opts.helm) throw new Error('An instance of core/Helm is required')
     if (!opts || !opts.k8) throw new Error('An instance of core/K8 is required')
     if (!opts || !opts.chartManager) throw new Error('An instance of core/ChartManager is required')

diff --git a/src/commands/mirror_node.mjs b/src/commands/mirror_node.mjs
@@ -25,8 +25,8 @@ import { getFileContents, getEnvValue } from '../core/helpers.mjs'
 
 export class MirrorNodeCommand extends BaseCommand {
   /**
-   * @param {{accountManager: AccountManager, profileManager: ProfileManager, logger: Logger, helm: Helm, k8: K8,
-   * hartManager: ChartManager, configManager: ConfigManager, depManager: DependencyManager,
+   * @param {{accountManager: AccountManager, profileManager: ProfileManager, logger: SoloLogger, helm: Helm, k8: K8,
+   * chartManager: ChartManager, configManager: ConfigManager, depManager: DependencyManager,
    * downloader: PackageDownloader}} opts
    */
   constructor (opts) {

diff --git a/src/commands/network.mjs b/src/commands/network.mjs
@@ -30,8 +30,9 @@ import fs from 'fs'
 
 export class NetworkCommand extends BaseCommand {
   /**
-   * @param {{profileManager: ProfileManager, logger: Logger, helm: Helm, k8: K8, chartManager: ChartManager,
-   * configManager: ConfigManager, depManager: DependencyManager, downloader: PackageDownloader}} opts
+   * @param {{profileManager: ProfileManager, logger: SoloLogger, helm: Helm, k8: K8, chartManager: ChartManager,
+   * configManager: ConfigManager, depManager: DependencyManager, downloader: PackageDownloader, keyManager: KeyManager,
+   * platformInstaller: PlatformInstaller}} opts
    */
   constructor (opts) {
     super(opts)