Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump versions of FST and platform #252

Merged
merged 8 commits into from
Apr 27, 2024
Merged

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Apr 27, 2024

Description

This pull request changes the following:

  • update versions of FST and platform for upcoming solo-workshop
  • branched off from release/v0.24.0 just to ensure it passes the tests and skips recent changes that might be causing some strange timeout issue (we'll fix in in main separately)
  • warmup cluster explicitly using warmup-cluster.sh (an attempt to reduce tests execution time to reduce timeouts)
  • Attempt to increase timeout
  • disable node refresh e2e as it seems to be unstable when run in conjunction with rest of the e2e

Related Issues

  • Closes #

@leninmehedy leninmehedy requested review from a team as code owners April 27, 2024 06:01
@leninmehedy leninmehedy changed the title fix: update versions of FST and platform fix: bump versions of FST and platform Apr 27, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Apr 27, 2024

Unit Test Results - Linux

  1 files  ±0   17 suites  ±0   1m 25s ⏱️ +11s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
139 runs  ±0  139 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9c5096e. ± Comparison against base commit 29fe5ee.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 27, 2024

Unit Test Results - Windows

  1 files  ±0   17 suites  ±0   1m 52s ⏱️ +27s
114 tests ±0  113 ✅  - 1  0 💤 ±0  1 ❌ +1 
139 runs  ±0  138 ✅  - 1  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 58d8a47. ± Comparison against base commit 29fe5ee.

♻️ This comment has been updated with latest results.

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy changed the base branch from main to release/0.24 April 27, 2024 06:44
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Apr 27, 2024

E2E Test Results

 1 files  ± 0  11 suites  ±0   10m 31s ⏱️ - 35m 35s
91 tests  -  1  75 ✅ + 1  16 💤 +16  0 ❌  - 18 
93 runs  +21  77 ✅ +22  16 💤 +16  0 ❌  - 17 

Results for commit 9c5096e. ± Comparison against base commit 29fe5ee.

This pull request removes 53 and adds 52 tests. Note that renamed tests count towards both.
 Test execution failure: could be caused by test hooks like 'afterAll'. ‑  Test execution failure: could be caused by test hooks like 'afterAll'.
MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment ‑ MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment
MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy ‑ MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy
MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command ‑ MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command
MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node start command ‑ MirrorNodeCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node start command
MirrorNodeCommand mirror node deploy should success ‑ MirrorNodeCommand mirror node deploy should success
MirrorNodeCommand mirror node destroy should success ‑ MirrorNodeCommand mirror node destroy should success
RelayCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment ‑ RelayCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should cleanup previous deployment
RelayCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy ‑ RelayCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with network deploy
RelayCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command ‑ RelayCommand Bootstrap network for test [release v0.47.0-alpha.0, keyFormat: pem] should succeed with node setup command
…
AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should cleanup previous deployment ‑ AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should cleanup previous deployment
AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should succeed with network deploy ‑ AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should succeed with network deploy
AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should succeed with node setup command ‑ AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should succeed with node setup command
AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should succeed with node start command ‑ AccountCommand Bootstrap network for test [release v0.48.1, keyFormat: pem] should succeed with node start command
AccountCommand account create/update command should be able to get account-1 ‑ AccountCommand account create/update command should be able to get account-1
AccountCommand account create/update command should be able to get account-2 ‑ AccountCommand account create/update command should be able to get account-2
AccountCommand account create/update command should create account with ecdsa private key and set alias ‑ AccountCommand account create/update command should create account with ecdsa private key and set alias
AccountCommand account create/update command should create account with no options ‑ AccountCommand account create/update command should create account with no options
AccountCommand account create/update command should create account with private key and hbar amount options ‑ AccountCommand account create/update command should create account with private key and hbar amount options
AccountCommand account create/update command should update account-1 ‑ AccountCommand account create/update command should update account-1
…

♻️ This comment has been updated with latest results.

This seems to be unstable and needs more attention separately.

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 29fe5ee1 85.71%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (29fe5ee) Report Missing Report Missing Report Missing
Head commit (9c5096e) 3038 2291 75.41%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#252) 7 6 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/0.24@29fe5ee). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.24     #252   +/-   ##
===============================================
  Coverage                ?   75.28%           
===============================================
  Files                   ?       33           
  Lines                   ?     3605           
  Branches                ?      598           
===============================================
  Hits                    ?     2714           
  Misses                  ?      891           
  Partials                ?        0           
Files Coverage Δ
src/commands/flags.mjs 94.44% <ø> (ø)
src/commands/network.mjs 51.92% <ø> (ø)
src/commands/node.mjs 57.25% <100.00%> (ø)
src/commands/relay.mjs 74.56% <100.00%> (ø)
test/test_util.js 90.58% <ø> (ø)
version.mjs 100.00% <100.00%> (ø)
src/commands/mirror_node.mjs 5.45% <0.00%> (ø)

Impacted file tree graph

@nathanklick nathanklick merged commit aa22b75 into release/0.24 Apr 27, 2024
19 of 20 checks passed
@nathanklick nathanklick deleted the solo-workshop-patch branch April 27, 2024 22:07
swirlds-automation added a commit that referenced this pull request Apr 27, 2024
## [0.24.1](v0.24.0...v0.24.1) (2024-04-27)

### Bug Fixes

* bump versions of FST and platform ([#252](#252)) ([aa22b75](aa22b75))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

leninmehedy added a commit that referenced this pull request May 7, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
leninmehedy pushed a commit that referenced this pull request May 7, 2024
## [0.24.1](v0.24.0...v0.24.1) (2024-04-27)

### Bug Fixes

* bump versions of FST and platform ([#252](#252)) ([aa22b75](aa22b75))
leninmehedy added a commit that referenced this pull request May 7, 2024
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
leninmehedy pushed a commit that referenced this pull request May 7, 2024
## [0.24.1](v0.24.0...v0.24.1) (2024-04-27)

### Bug Fixes

* bump versions of FST and platform ([#252](#252)) ([aa22b75](aa22b75))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants