Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): Add the new custom process output class and inject it into the default list renderer options #622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

Description

Add the new custom process output class and inject it into the default list renderer options

Related Issues

…t list renderer options

Signed-off-by: instamenta <instamenta@abv.bg>
@instamenta instamenta self-assigned this Sep 20, 2024
@instamenta instamenta requested review from leninmehedy and a team as code owners September 20, 2024 08:54
@instamenta instamenta linked an issue Sep 20, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   30s ⏱️ +2s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f52d111. ± Comparison against base commit e4932c4.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   53s ⏱️ -1s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f52d111. ± Comparison against base commit e4932c4.

Copy link
Contributor

E2E Test Report

 10 files  ±0   20 suites  ±0   49m 19s ⏱️ -13s
170 tests ±0  170 ✅ ±0  0 💤 ±0  0 ❌ ±0 
173 runs  ±0  173 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f52d111. ± Comparison against base commit e4932c4.

1 similar comment
Copy link
Contributor

E2E Test Report

 10 files  ±0   20 suites  ±0   49m 19s ⏱️ -13s
170 tests ±0  170 ✅ ±0  0 💤 ±0  0 ❌ ±0 
173 runs  ±0  173 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f52d111. ± Comparison against base commit e4932c4.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e4932c4) 4070 3295 80.96%
Head commit (f52d111) 4071 (+1) 3297 (+2) 80.99% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#622) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (e4932c4) to head (f52d111).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   80.83%   80.84%           
=======================================
  Files          37       37           
  Lines        4885     4880    -5     
  Branches      761      761           
=======================================
- Hits         3949     3945    -4     
+ Misses        936      935    -1     
Files with missing lines Coverage Δ
src/core/logging.mjs 55.55% <100.00%> (-1.59%) ⬇️

Impacted file tree graph

} else if (fd === process.stderr.fd) {
this._logger.error(`Listr Process stderr: ${message}`)
} else {
this._logger.info(`Listr Process log: ${message}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run mirror_node.test.mjs and do a search in ~/.solo/logs/solo.log, I can't find any references to Listr Process

Signed-off-by: instamenta <instamenta@abv.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update logging.mjs Logger to be a class
2 participants