Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AWS Regions for validation #111

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates hashicorp/terraform-provider-aws#23116.
Adds missing ap-northeast-3 and ap-southeast-3 AWS Regions (plus others) for validation.

% go test -v '-run=TestValidateRegion' .
=== RUN   TestValidateRegion
=== RUN   TestValidateRegion/us-east-1
=== RUN   TestValidateRegion/ap-northeast-3
=== RUN   TestValidateRegion/us-gov-west-1
=== RUN   TestValidateRegion/cn-northwest-1
=== RUN   TestValidateRegion/invalid
--- PASS: TestValidateRegion (0.00s)
    --- PASS: TestValidateRegion/us-east-1 (0.00s)
    --- PASS: TestValidateRegion/ap-northeast-3 (0.00s)
    --- PASS: TestValidateRegion/us-gov-west-1 (0.00s)
    --- PASS: TestValidateRegion/cn-northwest-1 (0.00s)
    --- PASS: TestValidateRegion/invalid (0.00s)
PASS
ok  	github.com/hashicorp/aws-sdk-go-base/v2	0.242s

Previously

=== RUN   TestValidateRegion/ap-northeast-3
    validation_test.go:40: Expected no error, received error: Invalid AWS Region: ap-northeast-3

@ewbankkit ewbankkit requested a review from a team as a code owner February 11, 2022 19:31
@ewbankkit ewbankkit requested review from gdavison and removed request for a team February 11, 2022 20:17
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@ewbankkit ewbankkit merged commit e2c7757 into v2 Feb 11, 2022
@ewbankkit ewbankkit deleted the b-add-newest-regions branch February 11, 2022 20:56
@gdavison gdavison restored the b-add-newest-regions branch February 16, 2022 01:48
gdavison added a commit that referenced this pull request Feb 16, 2022
@gdavison gdavison deleted the b-add-newest-regions branch February 16, 2022 01:52
@gdavison
Copy link
Contributor

Re-merged to the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants