Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-agent strings to request context #318

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

gdavison
Copy link
Contributor

Allow passing additional user-agent strings in the AWS API request context. Supports module-scoped user-agent strings in Terraform providers.

@gdavison gdavison requested a review from a team as a code owner June 27, 2022 23:03
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test ./...   
ok  	github.com/hashicorp/aws-sdk-go-base/v2	1.725s
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	1.446s
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	1.286s

@gdavison gdavison merged commit 406197c into main Aug 31, 2022
@gdavison gdavison deleted the user-agent-from-context branch August 31, 2022 21:24
gdavison added a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants