Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new AWS Region, me-central-1 #328

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add new AWS Region, me-central-1 #328

merged 1 commit into from
Aug 31, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 31, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #327.

% go test -v ./internal/endpoints
=== RUN   TestPartitionForRegion
--- PASS: TestPartitionForRegion (0.00s)
PASS
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	0.789s

@ewbankkit ewbankkit requested a review from a team as a code owner August 31, 2022 13:53
gdavison
gdavison approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@gdavison gdavison merged commit 43a2a23 into main Aug 31, 2022
@gdavison gdavison deleted the f-add-me-central-1 branch August 31, 2022 21:22
gdavison added a commit that referenced this pull request Aug 31, 2022
@gdavison
Updates CHANGELOG for #328
c2d55d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new me-central-1 AWS Region to internal/endpoints/endpoints.go
2 participants
@ewbankkit @gdavison