Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds full proxy configuration #775

Merged
merged 16 commits into from
Nov 14, 2023
Merged

Adds full proxy configuration #775

merged 16 commits into from
Nov 14, 2023

Conversation

gdavison
Copy link
Contributor

Adds HttpsProxy and NoProxy parameters and support for HTTPS_PROXY, http_proxy, NO_PROXY, and no_proxy environment variables

Closes #133

@gdavison gdavison requested a review from a team as a code owner November 11, 2023 08:18
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% go test -count=1 ./...
?       github.com/hashicorp/aws-sdk-go-base/v2/configtesting   [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig      [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/constants      [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/errs   [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/slices [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/internal/test   [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/mockdata        [no test files]
?       github.com/hashicorp/aws-sdk-go-base/v2/servicemocks    [no test files]
ok      github.com/hashicorp/aws-sdk-go-base/v2 4.720s
ok      github.com/hashicorp/aws-sdk-go-base/v2/diag    0.215s
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/config 0.338s
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints      0.257s
ok      github.com/hashicorp/aws-sdk-go-base/v2/internal/expand 0.251s
ok      github.com/hashicorp/aws-sdk-go-base/v2/logging 0.269s
ok      github.com/hashicorp/aws-sdk-go-base/v2/tfawserr        0.193s
ok      github.com/hashicorp/aws-sdk-go-base/v2/useragent       0.219s
ok      github.com/hashicorp/aws-sdk-go-base/v2/validation      0.265s

config.go Outdated Show resolved Hide resolved
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
@gdavison gdavison merged commit 110a94d into main Nov 14, 2023
12 checks passed
@gdavison gdavison deleted the b-proxy-config branch November 14, 2023 19:45
gdavison added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NoProxy parameter
2 participants