Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: Fix display issue with bullets and code into stable-website #3335

Conversation

hc-github-team-secure-boundary
Copy link
Collaborator

Backport

This PR is auto-generated from #3333 to be assessed for backporting due to the inclusion of the label backport/website.

The below text is copied from the body of the original PR.


When the text inside a bullet begins with code, our renderer changes the text to a link. The link doesn't go anywhere when you click it, creating a bad user experience:

image

I discussed it with the DevDot team, and this is a limitation of our system; there is no fix for it at this time.

I thought I figured out a workaround by adding the HTML entity for a space ( ) before the text for the bullet. The extra space prevented the code from rendering as a link, and Markdown ignored it as a duplicate space. This worked great on my local machine and in Vercel previews:

image

However, when these updates were published, they did not render the same way in our production environment. The extra space is turning those bullet points into code blocks:

image

This user experience is worse than having links that don't go anywhere. So this PR gets rid of the extra spaces and puts everything back to our standard format.

@hc-github-team-secure-boundary hc-github-team-secure-boundary merged commit 5697e40 into stable-website Jun 15, 2023
@hc-github-team-secure-boundary hc-github-team-secure-boundary force-pushed the backport/dheath-fix-spacing-bullets/code/specially-meet-skink branch from 6dc4cb8 to fd58a8a Compare June 15, 2023 17:05
@hc-github-team-secure-boundary hc-github-team-secure-boundary deleted the backport/dheath-fix-spacing-bullets/code/specially-meet-skink branch June 15, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant