Adds a toMap function which converts a ServiceTags element into a map. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to use the Registrator (http://gliderlabs.com/registrator) / Consul-Template tools in order to dynamically configure Apache. Since Consul does not support Registrator's Attributes, and can only work with labels, a method of having key-values is necessary. By creating key=value labels, one can achieve this.
|
Hey @etlweather Thank you for the Pull Request. I understand this is a real problem you are facing, but I am against adding this kind of function to Consul Template. Instead, we are going to work to add this kind of metadata support as a first-class citizen in Consul itself. Please track hashicorp/consul#1107 for that work. Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to use the Registrator / Consul-Template tools in order to dynamically configure Apache. Since Consul does not support Registrator's Attributes, and can only work with labels, a method of having key-values is necessary. By creating
key=valuelabels, one can achieve this.