UI cleanup follow up from #3245. (#3251)

* Removes unnecessary set for model component which will be null. * Returns a 404 for a missing node, not a 200 with an empty response. * Updates built-in web assets.
hashicorp · Jul 10, 2017 · 7200b8c · 7200b8c
1 parent c2c28d5
commit 7200b8c
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 38 deletions.
diff --git a/agent/bindata_assetfs.go b/agent/bindata_assetfs.go
diff --git a/agent/ui_endpoint.go b/agent/ui_endpoint.go
@@ -96,7 +96,11 @@ RPC:
 			info.Checks = make([]*structs.HealthCheck, 0)
 		}
 		return info, nil
+	} else {
+		resp.WriteHeader(http.StatusNotFound)
+		return nil, nil
 	}
+
 	return nil, nil
 }
 

diff --git a/ui/javascripts/app/routes.js b/ui/javascripts/app/routes.js
@@ -356,12 +356,6 @@ App.NodesShowRoute = App.BaseRoute.extend({
       controller.set('content', models.node);
       controller.set('sessions', models.sessions);
       controller.set('tomography', models.tomography);
-      //
-      // Since we have 2 column layout, we need to also display the
-      // list of nodes on the left. Hence setting the attribute
-      // {{nodes}} on the controller.
-      //
-      controller.set('nodes', models.nodes);
   }
 });