Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leak: RPC Client Connections #149

Closed
abursavich opened this issue May 14, 2014 · 1 comment
Closed

Leak: RPC Client Connections #149

abursavich opened this issue May 14, 2014 · 1 comment

Comments

@abursavich
Copy link
Contributor

It looks like all RPC connections are added to a map but not all connections are removed from the map. The leaky cases are when:

Only connections of the type Consul are removed from the map.

@abursavich abursavich changed the title Leak: RPC Clients Leak: RPC Client Connections May 14, 2014
@armon armon closed this as completed in 03a98ed May 15, 2014
@armon
Copy link
Member

armon commented May 15, 2014

Thanks for the report! We actually don't even need to bother track the clients. We were previously doing it to Close() the conn, but that will happen on Shutdown anyways.

duckhan pushed a commit to duckhan/consul that referenced this issue Oct 24, 2021
sync-catalog tok8s lowercase service names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants