Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ca_file should allow multiple PEM-encoded certificates #167

Closed
nelhage opened this issue May 22, 2014 · 2 comments · Fixed by #174
Closed

ca_file should allow multiple PEM-encoded certificates #167

nelhage opened this issue May 22, 2014 · 2 comments · Fixed by #174

Comments

@nelhage
Copy link
Contributor

nelhage commented May 22, 2014

It would be very useful (and a very common practice for software that accepts a CA file) for the ca_file option to allow passing in multiple PEM-encoded certificates. Being able to specify multiple allowed CAs would be nice for several reasons, such as giving each datacenter their own CA, or allowing incremental migrations between an old CA and a new CA across an entire cluster.
@armon
Copy link
Member

armon commented May 22, 2014

Are you saying you want to provide multiple files, or that a single file should support multiple PEM certificates?

@nelhage
Copy link
Contributor Author

nelhage commented May 22, 2014

The standard thing here (afaik) is to allow multiple PEM-encoded certificates in a single file. crypto.x509 even has a helper method on CertPool to this end: http://godoc.org/crypto/x509#CertPool.AppendCertsFromPEM

nelhage added a commit to nelhage/consul that referenced this issue May 26, 2014
@nelhage
Allow multiple PEM-encoded certificates in the ca_file.
fe4ec67 
fixes hashicorp#167
@nelhage nelhage mentioned this issue May 26, 2014
Merged
duckhan pushed a commit to duckhan/consul that referenced this issue Oct 24, 2021
@lkysow
Merge pull request hashicorp#167 from hashicorp/fix-coalesce-test
fc9fb18 
Fix flaky coalesce test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow multiple PEM-encoded certificates in the ca_file. nelhage/consul
2 participants
@nelhage @armon