Add setting to skip ssl certificate verification for HTTP checks #1984
Conversation
kylemcc
force-pushed
the
https-check-skip-verify
branch
from
67113f9 to
e290599
Compare
kylemcc
force-pushed
the
https-check-skip-verify
branch
from
e290599 to
b5744e6
Compare
| check.Stop() | ||
| server.Close() | ||
|
|
||
| server = mockTLSHTTPServer(500) |
There was a problem hiding this comment.
Not sure we need to go into this in the tests, since we want to test that we are failing at the transport layer really. Doesn't hurt to keep it, though.
|
Hey @kylemcc, this looks great! Just a few minor comments but otherwise LGTM. Sorry for the delay! |
|
Great! I'll get on those tonight. |
kylemcc
force-pushed
the
https-check-skip-verify
branch
from
b5744e6 to
9bf99d6
Compare
| t.Fatalf("should be critical %v", mock.state) | ||
| } | ||
|
|
||
| if !strings.Contains(mock.output["skipverify_false"], "certificate signed by unknown authority") { |
There was a problem hiding this comment.
@ryanuber Based on your feedback, I've updated this test to make sure we're failing at the transport layer
|
@ryanuber I've made a few changes based on your feedback. The test failure here seems unrelated to my changes - it may be due to my rebasing on top of master. They do pass for me locally though. Let me know if you have any other feedback. |
|
@kylemcc great, will review again shortly! |
|
Hey guys, are there any information when this PR will be merged? We are very interested in using the new option! |
kylemcc
force-pushed
the
https-check-skip-verify
branch
from
a4045ca to
6a596da
Compare
kylemcc
force-pushed
the
https-check-skip-verify
branch
from
6a596da to
7f208d7
Compare
|
Thanks! |
This pull request adds the same functionality as #1897, but does so by adding a setting to the check definition so that verification can be turned off on a per-check basis. I've also included some unit tests and updated the documentation to reflect the change.
E.g.:
{ "check": { "id": "api", "name": "HTTPS check on localhost", "http": "https://localhost/health", "interval": "10s", "timeout": "1s", "tls_skip_verify": true } }