Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for https check with selfsigned certificate #261

Closed
pwielgolaski opened this issue Dec 10, 2016 · 2 comments
Closed

Add support for https check with selfsigned certificate #261

pwielgolaski opened this issue Dec 10, 2016 · 2 comments
Labels
enhancement
Milestone
1.3.0.RC1

Comments

@pwielgolaski
Copy link
Contributor

It seems new feature from consul that was implemented by PR hashicorp/consul#1984 and is available in 0.7.1.

I created PR for consul-api Ecwid/consul-api#83 to support it
@vivekasingh
Copy link

+1. In my project we are planning to use consul as discovery service and do register services with https health checks and self signed certificate and this merge is the key for us to move forward.

@spencergibb
Copy link
Member

spencergibb commented Feb 17, 2017 •
edited
Loading

@vivekasingh this is depending on the consul-api PR, nothing I can do here yet. Go vote there.

@PattiShortCake PattiShortCake mentioned this issue May 26, 2017
Merged
spencergibb pushed a commit that referenced this issue Jun 13, 2017
@PattiShortCake @spencergibb
Add ability to skip certificate verification during service checks (#312
8752842 
)

* Add ability to skip certificate verification during service checks

Fixes gh-261

* Update to randomized port and class name based on feedback

* Move properties to @SpringBootTest

* Format code using Spring Cloud Build formatter

* Remove unused imports
@spencergibb spencergibb added this to the 1.3.0.M1 milestone Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.3.0.RC1
Development

No branches or pull requests
3 participants
@spencergibb @vivekasingh @pwielgolaski