Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul built-in assets missing font files #2485

Closed
slackpad opened this issue Nov 8, 2016 · 5 comments
Closed

Consul built-in assets missing font files #2485

slackpad opened this issue Nov 8, 2016 · 5 comments
Labels
archived/webui This was used for v1/ui type/bug Feature does not function as expected
Milestone

Comments

@slackpad
Copy link
Contributor

slackpad commented Nov 8, 2016

If you do a wget -r against the internal UI there are some missing assets:

--2016-11-08 14:54:37--  http://localhost:8500/ui/fonts/glyphicons-halflings-regular.eot
Reusing existing connection to localhost:8500.
HTTP request sent, awaiting response... 500 Internal Server Error
2016-11-08 14:54:37 ERROR 500: Internal Server Error.

--2016-11-08 14:54:37--  http://localhost:8500/ui/fonts/glyphicons-halflings-regular.eot?
Reusing existing connection to localhost:8500.
HTTP request sent, awaiting response... 500 Internal Server Error
2016-11-08 14:54:37 ERROR 500: Internal Server Error.

--2016-11-08 14:54:37--  http://localhost:8500/ui/fonts/glyphicons-halflings-regular.woff
Reusing existing connection to localhost:8500.
HTTP request sent, awaiting response... 500 Internal Server Error
2016-11-08 14:54:37 ERROR 500: Internal Server Error.

--2016-11-08 14:54:37--  http://localhost:8500/ui/fonts/glyphicons-halflings-regular.ttf
Reusing existing connection to localhost:8500.
HTTP request sent, awaiting response... 500 Internal Server Error
2016-11-08 14:54:37 ERROR 500: Internal Server Error.

--2016-11-08 14:54:37--  http://localhost:8500/ui/fonts/glyphicons-halflings-regular.svg
Reusing existing connection to localhost:8500.
HTTP request sent, awaiting response... 500 Internal Server Error
2016-11-08 14:54:37 ERROR 500: Internal Server Error.

We should fix this and add a check to the ui build to catch these.

@slackpad slackpad added type/bug Feature does not function as expected archived/webui This was used for v1/ui labels Nov 8, 2016
@brianshumate
Copy link
Member

I took a look at this because I'd like to fix it, but it looks like GLYPHICONS Halflings icons / icon font are licensed in a manner that is incompatible with open source projects.

From the You must not list:

include icons in open-source projects, since this license is not compatible with most of the open-source licenses

@slackpad
Copy link
Contributor Author

Hmm - let's audit to see where we use them. Maybe we can get rid of them completely as a way forward.

@brianshumate
Copy link
Member

Sounds good! I would also be happy to find a more open source friendly alternative and implement them as well.

@brianshumate
Copy link
Member

brianshumate commented Nov 18, 2016

They're apparently included under a special provision with Bootstrap:

Glyphicons Halflings are normally not available for free, but their creator has made them available for Bootstrap free of cost. As a thank you, we only ask that you include a link back to Glyphicons whenever possible.

They are referenced in our minified Bootstrap CSS in ui/static/bootstrap.min.css, but it does not appear that we actually use them:

pwd
/Users/brian/src/hashicorp/consul
grep -r --exclude="bootstrap*" glyphicon .

We could remove the @font-face entries from the static minified bootstrap.min.css for an instant resolution of this issue, but to avoid this going forward, we'd have to customize Bootstrap further and deselect the Glyphicons component.

@slackpad
Copy link
Contributor Author

Trimming our bootstrap build sounds like the way to go.

@slackpad slackpad added this to the 0.7.2 milestone Nov 22, 2016
slackpad added a commit that referenced this issue Nov 23, 2016
Bootstrap w/o Glyphicon Halflings (resolves #2485)
johncowen pushed a commit that referenced this issue May 4, 2018
- Remove reference to Glyphicon Halflings @fontface
- Remove unused Glphyicon related classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived/webui This was used for v1/ui type/bug Feature does not function as expected
Projects
None yet
Development

No branches or pull requests

2 participants