-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul built-in assets missing font files #2485
Comments
I took a look at this because I'd like to fix it, but it looks like GLYPHICONS Halflings icons / icon font are licensed in a manner that is incompatible with open source projects. From the You must not list:
|
Hmm - let's audit to see where we use them. Maybe we can get rid of them completely as a way forward. |
Sounds good! I would also be happy to find a more open source friendly alternative and implement them as well. |
They're apparently included under a special provision with Bootstrap:
They are referenced in our minified Bootstrap CSS in
We could remove the |
Trimming our bootstrap build sounds like the way to go. |
Bootstrap w/o Glyphicon Halflings (resolves #2485)
If you do a
wget -r
against the internal UI there are some missing assets:We should fix this and add a check to the ui build to catch these.
The text was updated successfully, but these errors were encountered: