Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intentional config behavior change? node-meta and node_meta merge no longer works #3716

Closed
nugend opened this issue Nov 28, 2017 · 0 comments
Closed

Intentional config behavior change? node-meta and node_meta merge no longer works #3716

nugend opened this issue Nov 28, 2017 · 0 comments
Labels
type/bug Feature does not function as expected
Milestone
1.0.2

Comments

@nugend
Copy link

nugend commented Nov 28, 2017

Prior to 1.0, node_meta from config files and node-meta from the command line would be merged together.

After 1.0 (I believe due to the general config file handling changes), this no longer works.

If intentional, that's fine. Just want to know if I should re-work how I am providing these configuration values or if that was an unintended consequence.

Thanks.
@slackpad slackpad added the type/bug Feature does not function as expected label Nov 28, 2017
@slackpad slackpad added this to the 1.0.2 milestone Nov 28, 2017
slackpad added a commit that referenced this issue Dec 14, 2017
@slackpad
Changes maps to merge vs. overwrite when processing configs.
98e8371 
Fixes #3716
@slackpad slackpad mentioned this issue Dec 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
2 participants
@nugend @slackpad